This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
backend/local: serial import engines with range overlap #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In the current implementation, if several engines' key ranges have overlap, each of them likely split the same range into different regions. Thus if these engines run import at the same time, there will be a lot of
Epoch not match
errors, and lightning may fail if all the retries failed.close #436
What is changed and how it works?
Add a btree to record all the running engine kv ranges, if a new engine start import but its range overlap with one or more range in the running engines, this engine will be lock until all the overlapped engine finish import phase.
After add lock for conflict ranges, there shouldn't be
EpochNotMatch
error anymore:Now after serially import engines, the
EpochNotMatch
error are all caused by big region auto split by tikv which is expected since the engines heavily overlapped with each other.Benchmark result:
We do the benchmark base on the following three datasets:
Check List
Tests
Side effects
Related changes
tidb-ansible
repository